Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure URIs as single strings instead of as scheme/hostname/port/path #60

Closed
cfryanr opened this issue Nov 8, 2019 · 0 comments · Fixed by #77
Closed

Configure URIs as single strings instead of as scheme/hostname/port/path #60

cfryanr opened this issue Nov 8, 2019 · 0 comments · Fixed by #77
Projects
authservice

Comments

@cfryanr
Copy link

cfryanr commented Nov 8, 2019

To make the authservice a little easier to configure, we could change the configuration format to take URIs as plain old URI strings instead of as structures of scheme/hostname/port/path.
@cfryanr cfryanr added this to To do in authservice Nov 8, 2019
cfryanr added a commit that referenced this issue Mar 5, 2020
@cfryanr @margocrawf
Consolidated configuration of uris into strings
529787e 
- Renamed `oidc.logout.redirect_to_uri` config option to `redirect_uri`
- Renamed `authorization`, `token`, and `callback` config options to
  `authorization_uri`, `token_uri`, and `callback_uri`
- Deleted the unused `jwks_uri` config option
- The `authorization_uri`, `token_uri`, and `callback_uri` config
  options became simple strings instead of `Endpoint` objects

[Issue #60]

Signed-off-by: Margo Crawford <mcrawford@pivotal.io>
cfryanr pushed a commit that referenced this issue Mar 5, 2020
@margocrawf @cfryanr
Consolidated configuration of uris into strings
74693c5 
- Renamed `oidc.logout.redirect_to_uri` config option to `redirect_uri`
- Renamed `authorization`, `token`, and `callback` config options to
  `authorization_uri`, `token_uri`, and `callback_uri`
- Deleted the unused `jwks_uri` config option
- The `authorization_uri`, `token_uri`, and `callback_uri` config
  options became simple strings instead of `Endpoint` objects

[Issue #60]

Signed-off-by: Ryan Richard <rrichard@pivotal.io>
andrewedstrom added a commit that referenced this issue Mar 6, 2020
@andrewedstrom @cfryanr
Validate URLs provided in the config file
eeedeed 
- Remove unneeded fixtures

[Issue #60]

Signed-off-by: Ryan Richard <rrichard@pivotal.io>
andrewedstrom pushed a commit that referenced this issue Mar 7, 2020
@cfryanr @andrewedstrom
Small refactors
6acb9ae 
- Make constant static
- Inline functions are labeled with `inline` keyword
- Use correct return type for move assignment operator

[Issue #60]

Signed-off-by: Andrew Edstrom <aedstrom@pivotal.io>
andrewedstrom added a commit that referenced this issue Mar 7, 2020
@andrewedstrom @cfryanr
Refactor the Uri class and introduce new PathQueryFragment class
a915d6f 
[Issue #60]

Signed-off-by: Ryan Richard <rrichard@pivotal.io>
andrewedstrom pushed a commit that referenced this issue Mar 9, 2020
@andrewedstrom
Getter methods for Uri class are prefixed with "Get-"
5b679d0 
This avoids a conflict we saw in gcc between the getter
"Uri::PathQueryFragment" and the class definition PathQueryFragment.

[Issue #60]

Signed-off-by: Andrew Edstrom <aedstrom@pivotal.io>
@andrewedstrom andrewedstrom mentioned this issue Mar 9, 2020
Closed
peterhaochen47 pushed a commit that referenced this issue Mar 12, 2020
@tylerschultz
Consolidated configuration of uris into strings
af81fe1 
- Renamed `oidc.logout.redirect_to_uri` config option to `redirect_uri`
- Renamed `authorization`, `token`, and `callback` config options to
  `authorization_uri`, `token_uri`, and `callback_uri`
- Deleted the unused `jwks_uri` config option
- The `authorization_uri`, `token_uri`, and `callback_uri` config
  options became simple strings instead of `Endpoint` objects

[Issue #60]

Signed-off-by: Tyler Schultz <tschultz@pivotal.io>
peterhaochen47 pushed a commit that referenced this issue Mar 12, 2020
@tylerschultz
Validate URLs provided in the config file
ecb2570 
- Remove unneeded fixtures

[Issue #60]

Signed-off-by: Peter Chen <pchen@pivotal.io>
peterhaochen47 pushed a commit that referenced this issue Mar 12, 2020
@tylerschultz
Small refactors
142a7b5 
- Make constant static
- Inline functions are labeled with `inline` keyword
- Use correct return type for move assignment operator

[Issue #60]

Signed-off-by: Andrew Edstrom <aedstrom@pivotal.io>
peterhaochen47 pushed a commit that referenced this issue Mar 12, 2020
@tylerschultz
Refactor the Uri class and introduce new PathQueryFragment class
b39df5a 
[Issue #60]

Signed-off-by: Ryan Richard <rrichard@pivotal.io>
peterhaochen47 pushed a commit that referenced this issue Mar 12, 2020
@tylerschultz
Getter methods for Uri class are prefixed with "Get-"
8f2991b 
This avoids a conflict we saw in gcc between the getter
"Uri::PathQueryFragment" and the class definition PathQueryFragment.

[Issue #60]

Signed-off-by: Andrew Edstrom <aedstrom@pivotal.io>
@peterhaochen47 peterhaochen47 mentioned this issue Mar 12, 2020
Merged
peterhaochen47 pushed a commit that referenced this issue Mar 12, 2020
@tylerschultz
Consolidated configuration of uris into strings
09db8e6 
- Renamed `oidc.logout.redirect_to_uri` config option to `redirect_uri`
- Renamed `authorization`, `token`, and `callback` config options to
  `authorization_uri`, `token_uri`, and `callback_uri`
- Deleted the unused `jwks_uri` config option
- The `authorization_uri`, `token_uri`, and `callback_uri` config
  options became simple strings instead of `Endpoint` objects

[Issue #60]

Signed-off-by: Peter Chen <pchen@pivotal.io>
peterhaochen47 pushed a commit that referenced this issue Mar 12, 2020
@tylerschultz
Validate URLs provided in the config file
943a6f4 
- Remove unneeded fixtures

[Issue #60]

Signed-off-by: Tyler Schultz <tschultz@pivotal.io>
peterhaochen47 pushed a commit that referenced this issue Mar 12, 2020
@tylerschultz
Small refactors
9b378f6 
- Make constant static
- Inline functions are labeled with `inline` keyword
- Use correct return type for move assignment operator

[Issue #60]

Signed-off-by: Peter Chen <pchen@pivotal.io>
peterhaochen47 pushed a commit that referenced this issue Mar 12, 2020
@tylerschultz
Refactor the Uri class and introduce new PathQueryFragment class
278cba3 
[Issue #60]

Signed-off-by: Tyler Schultz <tschultz@pivotal.io>
peterhaochen47 pushed a commit that referenced this issue Mar 12, 2020
@tylerschultz
Getter methods for Uri class are prefixed with "Get-"
21b5177 
This avoids a conflict we saw in gcc between the getter
"Uri::PathQueryFragment" and the class definition PathQueryFragment.

[Issue #60]

Signed-off-by: Peter Chen <pchen@pivotal.io>
authservice automation moved this from To do to Done Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
authservice
  
Done
Milestone
No milestone
1 participant
@cfryanr