Update code owners #248
Merged
Update code owners #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=======================================
Coverage ? 90.31%
=======================================
Files ? 24
Lines ? 1569
Branches ? 0
=======================================
Hits ? 1417
Misses ? 108
Partials ? 44 |
|
/hold |
Shikugawa
approved these changes
Apr 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nacx, Shikugawa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm. |
|
/unhold |
|
It's been 1 week and there were no objections, so let's have this merged. We can always add back any maintainer that wants to be a code owner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the code owners to the current active people, so that code reviews can happen in a timely manner.
It mgirates from the OWNERS file to GitHub CODEOWNERS. Once this is merged, a follow-up change will be done in
istio/test-infrato update the Ci requirements accordingly.@BrenoDeMedeiros @liminw @lizan @sawlanipradeep @incfly @Shikugawa you were listed in the OWNERS file, but as far as I know you're not active anymore in the project. Please leave a comment if you want to be kept in the CODEOWNERS file and I would be happy to add you before merging the PR. Thank you! :)