Move the state and nonce from an encrypted cookie into the session store #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes two configuration options that are no longer needed: `cryptor_secret` and `timeout` - Removes the cookie encryption code and related helpers - Does not set or delete the state cookie anymore - Adds the state and nonce values to the session store - Renamed the SessionIdGenerator to SessionStringGenerator because it now also generates state and nonce values [Issue #69] Signed-off-by: Andrew Chang <anchang@pivotal.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cfryanr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
- Remove an unused include in in_memory_session_store_test.cc - Add a new target in the Makefile to help run focused tests from the command line [Issue #69] Signed-off-by: Ryan Richard <rrichard@pivotal.io>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69