releasing binaries for darwin and linux #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro H. Spagiari <pedro.spagiari@unico.io>
LuisFigueiredo2021
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the build and release for both OS (Linux and MacOS).
When I tried to use the migrate_addon in a macos system I faced the problem of the script only works for linux and the downloaded
convertbinary was only available for linux as well.It was easy to run the script on a macos simply installing
coreutilsand building theconvertbinary fordarwinOS. With that, this PR proposes to have binaries for both OS.If you guys agree with that approach I will also open a Pull Request for
migrate-addonto enable macos usage.