-
Notifications
You must be signed in to change notification settings - Fork 536
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Deprecate int percent in favor of double percentage (#609)
* Deprecate int percent in favor of FractionalPercent This commit deprecates the integer percent field in Delay and Abort types in favor of the new FractionalPercent type which allows finer control. Signed-off-by: Venil Noronha <veniln@vmware.com> * Remove FractionalPercent and use double for percentage Signed-off-by: Venil Noronha <veniln@vmware.com> * Fix docs related to the percentage field Signed-off-by: Venil Noronha <veniln@vmware.com> * Copy envoy.type.Percent proto definition * The "type" in envoy.type.Percent is renamed to "types" in istio.envoy.types.Percent to avoid a keyword conflict in Golang. * The Makefile splits the *.pb.go file generation for v2alpha1/*.proto and types/*.proto in order to avoid the "inconsistent package names" error in protoc-gen-go. Signed-off-by: Venil Noronha <veniln@vmware.com> * Use istio.envoy.types.Percent for percentage Signed-off-by: Venil Noronha <veniln@vmware.com> * Revert copy envoy.type.Percent and its usage Signed-off-by: Venil Noronha <veniln@vmware.com> * Add and use Percent type in virtual_service.proto Signed-off-by: Venil Noronha <veniln@vmware.com>
- Loading branch information
1 parent
864a733
commit 214c759
Showing
5 changed files
with
503 additions
and
152 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.