[Manual Cherry-Pick] Fix quantity and lock down others to a more specific type (#1567) #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix quantity and lock down others to correct IntOrString Signed-off-by: Liam White <liam@tetrate.io> * fix imports Signed-off-by: Liam White <liam@tetrate.io>
googlebot
added
the
cla: yes
istio-testing
added
the
size/L
|
@liamawhite are those tests supposed to fail? |
|
It seems to be failing on a merge conflict with master. This is the same failure that required me to do a manual cherry-pick. So ¯_(ツ)_/¯? |
|
api repo is too complicated to me... perhaps this should get merged in master first? #1551 |
|
I think its probably safe to merge otherwise those tests would be required? |
|
oh, I know what's going on here. The failed tests are tests from master. Not sure why they were triggered in this PR. Have you changed the branch target of this PR after it was created? |
jwendell
approved these changes
Aug 5, 2020
Mythra
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Liam White liam@tetrate.io
Signed-off-by: Liam White liam@tetrate.io