Add two new attributes: request.url_path and request.query_params #566
Conversation
googlebot
added
the
cla: yes
mixer/v1/global_dictionary.yaml
Outdated
| @@ -68,6 +68,8 @@ | |||
| - request.size | |||
| - request.time | |||
| - request.useragent | |||
| - request.queries | |||
There was a problem hiding this comment.
This file is append-only, unfortunately.
There was a problem hiding this comment.
Moved them to the end of file.
|
These are traditionally called query parameters, not queries. There is one
query string per request, several components in it, first one being path
and the remainder are parameters
…On Tue, Jul 3, 2018, 9:00 AM Douglas Reid ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In mixer/v1/global_dictionary.yaml
<#566 (comment)>:
> @@ -68,6 +68,8 @@
- request.size
- request.time
- request.useragent
+- request.queries
This file is append-only, unfortunately.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#566 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJGIxnxASHmtLFenWJOaQU5K0gxhJXXnks5uC5UsgaJpZM4VBNjR>
.
|
|
@kyessenov @douglas-reid I've updated |
kyessenov
changed the title
|
Since this PR is parked, do you mind adding two keywords: "inbound" and "outbound". They would help compress reporter kind strings. |
|
Please document whether the string is normalized based on spec. For
example, + vs %20.
|
bianpengyuan
force-pushed
the
request-header-attr
branch
from
e8fcbbe
to
384f2f0
Compare
|
@wora comment updated, thanks!. @kyessenov @douglas-reid Please take another look, thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglas-reid, kyessenov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The two attributes will be populated by istio/proxy#1837
cc @douglas-reid @kyessenov @qiwzhang