Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote external control plane feature to beta #93

Merged
merged 6 commits into from
Aug 9, 2021
Merged

Promote external control plane feature to beta #93

merged 6 commits into from
Aug 9, 2021

Conversation

frankbu
Copy link
Contributor

@frankbu frankbu commented Jul 9, 2021 •
edited
Loading

The external control plane feature is functionally ready to be promoted to Beta.

The only possible issue is that it's somewhat light on testing, although it does have basic integration testing and doc testing which should be sufficient for Beta promotion in release 1.11. More robust and complete testing will be added in 1.12+ in preparation for later promotion to Stable.

Current Test Summary

  1. Doc test for helloworld service and gateway deployment with single cluster external control plane setup.
  2. Doc test for helloworld running on two clusters (config and remote), i.e., a multicluster external control plane setup.
  3. Integration test for single config cluster with external control plane - confirms istiod connectivity including injection webhook is functioning.
  4. Integration test for multicluster reachability using an external control plane (TBD: will be added before 1.11 release)

@frankbu frankbu requested a review from a team as a code owner July 9, 2021 19:24
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2021
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 9, 2021
@frankbu frankbu mentioned this pull request Jul 22, 2021
Closed
@frankbu frankbu requested a review from a team as a code owner July 23, 2021 14:45
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2021
@frankbu frankbu changed the title Update external istiod feature Promote external control plane feature to beta Jul 23, 2021
brian-avery
brian-avery reviewed Jul 23, 2021
View reviewed changes
features/external_istiod.md
@@ -135,7 +135,7 @@ No API added in 1.8
- [x] Documentation on istio.io includes performance expectations; may have caveats.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the unchecked items here already completed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be, sort of :) I've add a discussion of this to the next TOC agenda.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New integration tests: istio/istio#34331

@frankbu frankbu added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 23, 2021
@frankbu
Copy link
Contributor Author

frankbu commented Aug 9, 2021

The integration test framework has now been updated to support the external control plane topology, and basic testing is in place. The remaining tests needed for the Integration tests cover feature edge cases checkbox already exist (MC test suite) and will be added to the external control plane suite in the next few weeks.

@frankbu frankbu removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Aug 9, 2021
@ericvn
Copy link
Contributor

ericvn commented Aug 9, 2021

/cherrypick release-1.11

@istio-testing
Copy link

@ericvn: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing merged commit baf23a6 into master Aug 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the external-istiod branch August 9, 2021 17:07
@istio-testing
Copy link

@ericvn: new pull request created: #100

In response to this:

/cherrypick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing mentioned this pull request Aug 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-avery brian-avery brian-avery left review comments

@smawson smawson smawson approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frankbu @ericvn @istio-testing @smawson @brian-avery