Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm and gateway tests #11276

Merged
merged 18 commits into from
Jun 7, 2022
Merged

Helm and gateway tests #11276

merged 18 commits into from
Jun 7, 2022

Conversation

dhawton
Copy link
Member

@dhawton dhawton commented May 7, 2022

Please provide a description for what this PR is for.

  • Add tests to gateway additional setup
  • Add tests to helm upgrades
  • Refactored the rewrite-repo function in multiple scripts into a util helper function, and modified the tests to use this helper function (discussed in Add Test to Gateway Setup #11268)

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

  • Configuration Infrastructure
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

@dhawton dhawton requested review from a team as code owners May 7, 2022 02:41
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 7, 2022
@dhawton
Copy link
Member Author

dhawton commented May 7, 2022

/retest-required

@dhawton dhawton added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 9, 2022
@dhawton dhawton removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 13, 2022
@jacob-delgado jacob-delgado requested a review from ericvn May 17, 2022 16:30
@jacob-delgado
Copy link
Contributor

Can you take a look at this @ericvn ? Thanks

@dhawton
Copy link
Member Author

dhawton commented May 23, 2022

/test doc.test.profile_default_istio.io

@dhawton
Copy link
Member Author

dhawton commented May 31, 2022

@frankbu I noticed Eric is on vacation, can you take a look? There is an issue in the helm upgrade docs that is fixed in this as well as adding tests.

frankbu
frankbu reviewed Jun 6, 2022
View reviewed changes
content/en/boilerplates/revision-tags-middle.md Outdated
Comment on lines 15 to 16
prod-canary 1-10-0...
prod-stable 1-9-5...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing the space before the ...? Isn't the ... supposed to be for the NAMESPACES column of the output?

@istio-testing istio-testing merged commit 63d5724 into istio:master Jun 7, 2022
@istio-testing istio-testing mentioned this pull request Jun 10, 2022
Merged
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #11394

@craigbox craigbox mentioned this pull request Jun 10, 2022
Open
@dhawton dhawton mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvn ericvn ericvn left review comments

@frankbu frankbu frankbu approved these changes

@jacob-delgado jacob-delgado jacob-delgado approved these changes

Assignees
No one assigned
Labels
kind/docs size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dhawton @jacob-delgado @istio-testing @frankbu @ericvn @craigbox @istio-policy-bot