Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Service Graph #2874

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Conversation

clyang82
Copy link
Member

Signed-off-by: Chun Lin Yang clyang@cn.ibm.com

istio/istio#9066 - ServiceGraph is deprecated in 1.1 in favor of Kiali. Remove the document accordingly.

Signed-off-by: Chun Lin Yang <clyang@cn.ibm.com>
@istio-testing
Copy link
Contributor

Hi @clyang82. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@clyang82
Copy link
Member Author

from this PR - #2715, just add a note for service graph deprecated. We don't want new users to discover and start using it. so propose to delete this staff. @geeknoid it is up to you. Thanks.

@geeknoid
Copy link
Contributor

/lgtm
/approve

@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, geeknoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit bf264f1 into istio:master Nov 14, 2018
vadimeisenbergibm pushed a commit to vadimeisenbergibm/vadimeisenbergibm.github.io that referenced this pull request Dec 3, 2018
Signed-off-by: Chun Lin Yang <clyang@cn.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants