Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh: add help/faq/telemetry/istio-copy-headers.md #2954

Merged
merged 1 commit into from
Jan 3, 2019
Merged

zh: add help/faq/telemetry/istio-copy-headers.md #2954

merged 1 commit into from
Jan 3, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Dec 7, 2018

zh-trans: add help/faq/telemetry/istio-copy-headers.md

@istio-testing
Copy link
Contributor

Hi @SataQiu. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SataQiu SataQiu mentioned this pull request Dec 7, 2018
Closed
@SataQiu
Copy link
Member Author

SataQiu commented Dec 7, 2018

/assign @rootsongjc

@rootsongjc
Copy link
Member

CI failed.

- ./public/about/contribute/style-guide/index.html
  *  External link http://stephanieleary.com/2015/05/why-click-here-is-a-terrible-link-and-what-to-write-instead/ failed: 500 No error
htmlproofer 3.9.2 | Error:  HTML-Proofer found 1 failure!

This is not a fault of yours, just waiting for the site recovery and re-lint.

rootsongjc
rootsongjc reviewed Dec 7, 2018
View reviewed changes
content_zh/help/faq/telemetry/istio-copy-headers.md Outdated
title: 为什么 Istio 不能传播 headers 而要传播应用程序？
weight: 10
---
<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要使用 HTML 注释，请去掉英文部分。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rootsongjc 感谢，英文部分已经去掉，合并 master，CI 已通过！

@rootsongjc rootsongjc added the translation/chinese Translation item label Dec 7, 2018
@rootsongjc rootsongjc changed the title zh-trans: add help/faq/telemetry/istio-copy-headers.md zh: add help/faq/telemetry/istio-copy-headers.md Dec 7, 2018
@SataQiu
Copy link
Member Author

SataQiu commented Jan 3, 2019

/assign @geeknoid

rootsongjc
rootsongjc reviewed Jan 3, 2019
View reviewed changes
content_zh/help/faq/telemetry/istio-copy-headers.md Outdated
@@ -0,0 +1,7 @@
---
title: 为什么 Istio 不能传播 headers 而要传播应用程序？
Copy link
Member

@rootsongjc rootsongjc Jan 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

传播应用程序？
header 不用使用复数形式

rootsongjc
rootsongjc reviewed Jan 3, 2019
View reviewed changes
content_zh/help/faq/telemetry/istio-copy-headers.md Outdated
---

尽管 Istio sidecar 将处理与之关联的应用程序实例的入站和出站请求，但它并不能隐式地将出站请求和与该出站请求对应的入站请求建立联系。
实现这种相关性的唯一方法是应用程序[传递从入站请求到出站请求的关联信息](/docs/tasks/telemetry/distributed-tracing)（比如，headers）。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请替换为中文链接
header 不用使用复数形式

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rootsongjc 多谢指正，已经修改！

@rootsongjc
Copy link
Member

/lgtm

@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rootsongjc, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit a3e243e into istio:master Jan 3, 2019
@SataQiu SataQiu mentioned this pull request Feb 15, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootsongjc rootsongjc rootsongjc left review comments

@fleeto fleeto Awaiting requested review from fleeto

@gyliu513 gyliu513 Awaiting requested review from gyliu513

Assignees

@rootsongjc rootsongjc

@geeknoid geeknoid

Labels
translation/chinese Translation item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SataQiu @istio-testing @rootsongjc @googlebot @geeknoid