Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line-wrapping for multi-cluster Helm commands #3193

Merged
merged 1 commit into from Feb 5, 2019

Conversation

nicktrav
Copy link
Contributor

@nicktrav nicktrav commented Feb 3, 2019

Currently, the command line snippet for setting up multi-cluster Istio
with Helm is confined to a single line. This makes it difficult to read
without having to scroll horizontally to read the entire command.

Update the command to be multi-line.

Signed-off-by: Nick Travers n.e.travers@gmail.com

Currently, the command line snippet for setting up multi-cluster Istio
with Helm is confined to a single line. This makes it difficult to read
without having to scroll horizontally to read the entire command.

Update the command to be multi-line.

Signed-off-by: Nick Travers <n.e.travers@gmail.com>
@istio-testing
Copy link
Contributor

Hi @nicktrav. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@geeknoid
Copy link
Contributor

geeknoid commented Feb 4, 2019

/approve
/lgtm

@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid, nicktrav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid geeknoid merged commit aa02682 into istio:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants