Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBM Platform update #3333

Merged
merged 1 commit into from
Feb 22, 2019
Merged

IBM Platform update #3333

merged 1 commit into from
Feb 22, 2019

Conversation

ericvn
Copy link
Contributor

@ericvn ericvn commented Feb 21, 2019

  • Added a section for using the new Istio add-on for IKS clusters
  • update IKS command to use --export. Mpt sure if we can totally move
    new ks command syntax yet.

- Added a section for using the new Istio add-on for IKS clusters
- update IKS command to use --export. Mpt sure if we can totally move
  new ks command syntax yet.
@istio-testing
Copy link
Contributor

Hi @ericvn. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericvn
Copy link
Contributor Author

ericvn commented Feb 21, 2019

@frankbu @linsun Update to the IBM Platform setup doc. I did take Managed Istio from an earlier PR.

@ericvn
Copy link
Contributor Author

ericvn commented Feb 21, 2019

/assign @frankbu

Copy link
Member

@sdake sdake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericvn, sdake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 29b79d8 into istio:master Feb 22, 2019
@ericvn ericvn deleted the IBMSetup branch February 25, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants