fix span name when using the OpenTelemetry tracing provider (#51072)

* fix TestProxyTracingOpenTelemetryProvider * root span name * fix span name * release-notes * updat proxy to latest
istio · May 15, 2024 · cf4ef83 · cf4ef83
1 parent b434956
commit cf4ef83
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/istio.deps b/istio.deps
@@ -4,7 +4,7 @@
     "name": "PROXY_REPO_SHA",
     "repoName": "proxy",
     "file": "",
-    "lastStableSHA": "db29233591803de3bab068eee51e5a0431fa2d76"
+    "lastStableSHA": "f352a04be1e2bc99776e80cd99af25377ab05266"
   },
   {
     "_comment": "",

diff --git a/releasenotes/notes/51072.yaml b/releasenotes/notes/51072.yaml
@@ -0,0 +1,6 @@
+apiVersion: release-notes/v2
+kind: bug-fix
+area: telemetry
+releaseNotes:
+  - |
+    **Fixed** an issue that span name isn't set when using the OpenTelemetry tracing provider.
diff --git a/tests/integration/telemetry/tracing/tracing.go b/tests/integration/telemetry/tracing/tracing.go
@@ -157,12 +157,12 @@ func VerifyOtelEchoTraces(t framework.TestContext, namespace, clName string, tra
 
 func WantOtelTraceRoot(namespace, clName string) (root zipkin.Span) {
 	serverSpan := zipkin.Span{
-		Name:        "ingress",
+		Name:        fmt.Sprintf("server.%s.svc.cluster.local:80/*", namespace),
 		ServiceName: fmt.Sprintf("server.%s", namespace),
 	}
 
 	root = zipkin.Span{
-		Name:        fmt.Sprintf("egress server.%s.svc.cluster.local", namespace),
+		Name:        fmt.Sprintf("server.%s.svc.cluster.local:80/*", namespace),
 		ServiceName: fmt.Sprintf("client-%s.%s", clName, namespace),
 		ChildSpans:  []*zipkin.Span{&serverSpan},
 	}