istio-proxy deprecated spam when starting (1.1.0)

[Stono]

Hey,
Istio-proxy on 1.1.0 absolutely spams the logs with an envoy depreciation warning:

[2019-03-20 21:13:45.866][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.866][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.867][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.867][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.867][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.867][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.867][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.867][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.867][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.867][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.867][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.867][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.867][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.868][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.868][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.868][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.868][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.868][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.868][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.868][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.868][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.
[2019-03-20 21:13:45.868][21][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.

356 times, when an app starts:

k -n platform-testing logs platform-testing-756c7d5b98-xrf8n -c istio-proxy |grep DEPRECATED| wc -l
     356

The unique items are:

'envoy.api.v2.Cluster.hosts'.
'envoy.api.v2.Listener.use_original_dst'.
'envoy.api.v2.listener.Filter.config'.
'envoy.api.v2.route.Route.per_filter_config'.
'envoy.config.filter.accesslog.v2.AccessLog.config'.
'envoy.config.filter.network.http_connection_manager.v2.HttpFilter.config'.
'envoy.config.trace.v2.Tracing.Http.config'.

[costinm]

@duderino we should prioritize this for 1.1.1 - there is also additional spam in pilot logs ( the service account list ). Probably low risk.

[wansuiye]

meet the same warning in istio 1.1.0

[esnible]

Related problem: #12294 . This Envoy deprecation warning is sent to the logs every 30 minutes.

[Stono]

@howardjohn saved the day for me here, as a work around add --proxyLogLevel="error" to your injector config to suppress the info noise

[PiotrSikora]

@costinm I'm confused as to why you assigned this one to me. Do you consider the fix for this to be silencing the deprecation logs (Envoy) instead of migrating off the deprecated fields (Pilot)?

[howardjohn]

Being undeprecated on Envoy side: envoyproxy/envoy#6346

[howardjohn]

Change has been merged into Envoy - not sure of our process for picking up Envoy changes, but this will be fixed once we do

[hzxuzhonghu]

Also these kind of logs Using deprecated option 'envoy.api.v2.Listener.use_original_dst'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.

[dotw]

meet the same logs in istio 1.1.1
[2019-04-03 03:20:53.383][20][warning][misc] [external/envoy/source/common/protobuf/utility.cc:129] Using deprecated option 'envoy.api.v2.route.Route.per_filter_config'. This configuration will be removed from Envoy soon. Please see https://github.com/envoyproxy/envoy/blob/master/DEPRECATED.md for details.

[howardjohn]

Would it be a horrible idea to just turn these logs off completely? We can pass --component-log-level misc:error.

I get the logs have a purpose and we shouldn't just ignore them, but that is a concern for Istio developers. Does a user of Istio ever care that we are using deprecated Envoy features? Probably not.

This does silence other misc logs, but brief look shower it is hardly used.

[esnible]

@howardjohn Turning off these logs would be a benefit for users. These messages are showing up in a lot of unrelated Issues because users think they reveal some problem:

#12960
#12755
#12720
#11960
#9113

However, if we depend on deprecated features of Envoy we will soon find ourselves in the position where Envoy removes support and we are stuck on a back-level Envoy unable to get urgent patches. Maybe we should prioritize moving to the newer Envoy-isms, and preventing this from happening in the future by failing builds whose logs reveal deprecation warnings?

[howardjohn]

I think the two issues are a bit orthogonal. We can care about not using deprecated features and hide that issue from users. AFAIK we are working on (at least some) of the features that have been deprecated, but I don't it warrants P0 priority.

Failing builds would be a step way to far I think - consider Envoy deprecates something, we have an engineer start working on a fix which takes ~1 month, during which nobody can build Istio. I don't think that is a good situation to be in.

So I agree with you mostly, but using a deprecated feature isn't that bad in the short term. As long as we have a plan, it really has no impact if we migrate 6 months before they remove the feature or 1 month.

FYI: https://github.com/envoyproxy/envoy/blob/master//CONTRIBUTING.md#breaking-change-policy

[howardjohn]

Draft of what the change would look like to disable the logs: #13182

[howardjohn]

Unfortunately can't/won't be in 1.1.x due to compatibility issues, but #13182 turns off these logs in 1.2, so I am going to close this as there is no more work to track