Helm podAntiAffinity templating error

[StefanCenusa]

Describe the bug

Helm charts fail to generate proper podAntiAffinity.

In my values.yaml file I define the following:

mixer:

  podAntiAffinityTermLabelSelector:
    - key: istio
      operator: In
      values: mixer
      topologyKey: kubernetes.io/hostname

and after running helm template I noticed it generates the following output:

        podAntiAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
          - podAffinityTerm:
              labelSelector:
                matchExpressions:
                - key: istio
                  operator: In
              topologyKey: kubernetes.io/hostname
            weight: 100

https://github.com/istio/istio/blob/release-1.1/install/kubernetes/helm/istio/templates/_affinity.tpl#L83

If I change .value in .values I get the expected output.

Thanks!

Expected behavior

        podAntiAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
          - podAffinityTerm:
              labelSelector:
                matchExpressions:
                - key: istio
                  operator: In
                  values:
                  - mixer
              topologyKey: kubernetes.io/hostname
            weight: 100

Version
branch: release-1.1

Installation
helm

[linsun]

@morvencao can you help this?

[morvencao]

@StefanCenusa Yes, you need to update value to values, since we can define multiple values separated by comma, check the example settings: https://github.com/istio/istio/blob/release-1.1/install/kubernetes/helm/istio/charts/mixer/values.yaml#L65

[StefanCenusa]

@morvencao I am confused. In my opinion there is a bug in _affinity.tpl file because this if will always be falsy, unless I have a weird definition like this in values.yaml:

mixer:

  podAntiAffinityTermLabelSelector:
    - key: istio
      operator: In
      value: mixer
      values: mixer
      topologyKey: kubernetes.io/hostname

Am I doing something wrong?

[morvencao]

@StefanCenusa Got it, I missed that.