Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locality LB outlierDetection requirement #12961

Closed
howardjohn opened this issue Apr 1, 2019 · 3 comments
Closed

Locality LB outlierDetection requirement #12961

howardjohn opened this issue Apr 1, 2019 · 3 comments
Assignees

Comments

@howardjohn
Copy link
Member

Currently:

  • For CDS, outlierDetection is required for both failover and distribute mode.
  • For EDS, outlierDetection is not required at all.

I think the correct behavior should be, require outlierDetection for failover mode, for CDS and EDS.

It is needed for failover, as without it we would never drop down to lower priority levels.

I do not see how it is needed for distribute though.

@hzxuzhonghu @liamawhite

@liamawhite
Copy link
Member

Agreed. Would be good if we can encapsulate this in the locality mutation functions, rather than relying on people remembering to check if outlier is on.

@howardjohn
Copy link
Member Author

This is still broken:

For EDS, outlierDetection is not required at all and it should be.

@howardjohn
Copy link
Member Author

Fixed in #14099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants