Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio 1.4.0 tracing service moved from port 80 to 9411 #19227

Closed
Stono opened this issue Nov 26, 2019 · 6 comments · Fixed by #19231 or istio/operator#650
Closed

Istio 1.4.0 tracing service moved from port 80 to 9411 #19227

Stono opened this issue Nov 26, 2019 · 6 comments · Fixed by #19231 or istio/operator#650
Assignees

Comments

@Stono
Copy link
Contributor

Stono commented Nov 26, 2019

Bug description
In istio 1.4.0, tracing.istio-system has moved from port 80 to 9411. There is already a zipkin.istio-system service in the namespace on 9411. Both services point to the same workload (Jaeger).

This is a breaking change for us so just wondering why it was made and if it was intentional, it should have been in the upgrade notes (as we have upstream systems talking to tracing.istio-system).

Expected behavior
Consistent service ports between releases or details in release notes explaining the changes.

OR if you're really honouring semver releases, 1.4.0 shouldn't have breaking changes from 1.3.x and a different service port could probably be classed as breaking.

Steps to reproduce the bug

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
1.4.0

How was Istio installed?

Environment where bug was observed (cloud vendor, OS, etc)

@Stono
Copy link
Contributor Author

Stono commented Nov 26, 2019

Associated commit appears to be 9e0887f#diff-264788198be8f0b9371c31fecce6d199 and issue #17204

@sdake
Copy link
Member

sdake commented Nov 26, 2019

Nodeport more trouble then it is worth... These two PRs need a revert. The author is free to resubmit the work.

@sdake sdake assigned sdake and unassigned morvencao Nov 26, 2019
@sdake
Copy link
Member

sdake commented Nov 26, 2019

Had a deeper look at the PR. With istioctl dashboard jeager for example, none of these config options are needed across any of the third party component charts. We should consider their removal.

@Stono for the moment, I am going to make a small surgical change that should exhibit the original behavior.

sdake pushed a commit to sdake/istio that referenced this issue Nov 26, 2019
Fixes: istio#19227

The tracing and zipkin services both point to the same workload with
the same port. Each service must use different ports. 1.4.0 has a
regression in this area.
@Stono
Copy link
Contributor Author

Stono commented Nov 26, 2019

Thanks @sdake - no huge urgency on my part, I've patched around it locally. Just don't want other users getting caught out when they upgrade to 1.4.0.

istio-testing pushed a commit that referenced this issue Nov 30, 2019
* Resolve regression in tracing

Fixes: #19227

The tracing and zipkin services both point to the same workload with
the same port. Each service must use different ports. 1.4.0 has a
regression in this area.

* Use correct port for zipkin service (9411)
istio-testing pushed a commit to istio-testing/istio that referenced this issue Nov 30, 2019
Fixes: istio#19227

The tracing and zipkin services both point to the same workload with
the same port. Each service must use different ports. 1.4.0 has a
regression in this area.
istio-testing added a commit that referenced this issue Nov 30, 2019
* Resolve regression in tracing

Fixes: #19227

The tracing and zipkin services both point to the same workload with
the same port. Each service must use different ports. 1.4.0 has a
regression in this area.

* Use correct port for zipkin service (9411)
sdake pushed a commit to sdake/istio that referenced this issue Dec 1, 2019
* Resolve regression in tracing

Fixes: istio#19227

The tracing and zipkin services both point to the same workload with
the same port. Each service must use different ports. 1.4.0 has a
regression in this area.

* Use correct port for zipkin service (9411)
sdake pushed a commit to sdake/operator that referenced this issue Dec 2, 2019
This should resolve the jaeger regression around ports. Additionally
other features have been added to the installer.

Fixes: istio/istio#19227
@sdake
Copy link
Member

sdake commented Dec 2, 2019

@Stono this was fixed by an unrelated commit that syncronized the operator with the installer charts after my PR to fix the installer charts had merged for 1.4.

Cheers
-steve

@sdake
Copy link
Member

sdake commented Dec 2, 2019

verified 1.4-dev (what will be 1.4.1) operator instantiates the services as follows

...
tracing                  ClusterIP      10.111.253.18    <none>          80/TCP                                                                                                                       13s
zipkin                   ClusterIP      10.97.243.159    <none>          9411/TCP                                                                                                                     14s

Cheers
-steve

istio-testing pushed a commit to istio/operator that referenced this issue Dec 2, 2019
This should resolve the jaeger regression around ports. Additionally
other features have been added to the installer.

Fixes: istio/istio#19227
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
Fixes: istio#19227

This PR mirrors: istio#19231

I am not confident this change is correct, however, it does revert back to the original
1.3 behavior. I don't understand why we want two services (zipkin and tracing). Should not
tracing be sufficient?

If we must retain zipkin and we want tracing to run on port 9411 (vs what it has been running
on which is port 80...) zipkin must run on some other port.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants