Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a shim to convert OOP adapter to use Envoy native API #23580

Closed
bianpengyuan opened this issue May 6, 2020 · 2 comments
Closed

Provide a shim to convert OOP adapter to use Envoy native API #23580

bianpengyuan opened this issue May 6, 2020 · 2 comments
Labels
area/extensions and telemetry lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed
Milestone

Comments

@bianpengyuan
Copy link
Contributor

As part of efforts for Mixer deprecation, we need a way for current out of process (OOP) adapter user to migrate off Mixer template based API. The long term solution is to convert out of process adapter to a Wasm filter. However this process could be time consuming and requires Wasm runtime to be production ready, which is not guaranteed to happen on 1.7.

As an interim step, a shim could be provided so that OOP adapter user could compile that with their adapter, which:

  • Consumes native Envoy extern-authz API for policy check and access log API for telemetry.
  • Is generated based on given Mixer instances/handlers/template/rules/adapter.
  • Does not support dynamic configuration.

Guide will be provided on istio.io about how to migrate off out of process adapter to use this shim generation tool. We also need to be very clear that this shim generator should only be considered as a short term solution for transition to Wasm and will only be supported until Wasm production ready release or the release after that.

@mandarjog @douglas-reid

@bianpengyuan bianpengyuan added this to the 1.7 milestone May 6, 2020
@JimmyCYJ JimmyCYJ modified the milestones: 1.7, 1.8 Jul 23, 2020
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Aug 5, 2020
@bianpengyuan bianpengyuan added lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed and removed lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while labels Aug 5, 2020
@douglas-reid
Copy link
Contributor

douglas-reid commented Aug 5, 2020

Remaining bits:

  • integration tests
  • documentation for 1.7 AND 1.8 usage

@bianpengyuan
Copy link
Contributor Author

bianpengyuan commented Aug 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extensions and telemetry lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed
Projects
None yet
Development

No branches or pull requests

4 participants