Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make injection template customizable for operator based installs. #28038

Closed
liamawhite opened this issue Oct 16, 2020 · 3 comments
Closed

Make injection template customizable for operator based installs. #28038

liamawhite opened this issue Oct 16, 2020 · 3 comments
Labels
area/environments kind/enhancement lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while

Comments

@liamawhite
Copy link
Member

liamawhite commented Oct 16, 2020

Describe the feature request
Currently, customising the sidecar injector template requires an overlay replacing the entire injection ConfigMap, not just the template.

  components:
    pilot:
      k8s:
        overlays:
        - apiVersion: v1
          kind: ConfigMap
          name: istio-sidecar-injector
          patches:
          - path: data
            value:
			  <entire-sidecar-injector-config-map-plus-modifications>

This will mean any fields set outside of the template (config or .Values) in the Operator API will need to be changed in this overlay as well. Ideally, I would like to provide/edit the injector template only.

[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@liamawhite
Copy link
Member Author

@howardjohn
Copy link
Member

f2f6f26 essentially supports this, you can add a custom template and then change the default template to be sidecar,my-custom-template and it will be overlayed.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Jul 19, 2021
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-01-19. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/environments kind/enhancement lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while
Projects
None yet
Development

No branches or pull requests

3 participants