Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: operator test #28182

Closed
wants to merge 6 commits into from
Closed

WIP: operator test #28182

wants to merge 6 commits into from

Conversation

ostromart
Copy link
Contributor

Testing the integration test.

@ostromart ostromart requested a review from a team as a code owner October 22, 2020 02:52
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Oct 22, 2020
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 22, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2020
@ostromart ostromart requested a review from a team as a code owner October 22, 2020 04:50
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2020
@shamsher31 shamsher31 mentioned this pull request Oct 22, 2020
Closed
howardjohn
howardjohn reviewed Oct 22, 2020
View reviewed changes
operator/docker/Dockerfile.operator Outdated
@@ -19,6 +19,7 @@ COPY operator /usr/local/bin/

# add operator manifests
COPY manifests/ /var/lib/istio/manifests/
RUN chown 1337:1337 -R /var/lib/istio/manifests/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can --chown on the COPY line. This will break distroless otherwise

@ostromart ostromart force-pushed the operator-e2e-test branch 7 times, most recently from 53ae682 to a8f57db Compare October 23, 2020 23:26
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Nov 8, 2020
@istio-testing
Copy link
Collaborator

@ostromart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Collaborator

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
release-notes_istio 48f37c7 link /test release-notes_istio
lint_istio 48f37c7 link /test lint_istio
integ-helm-tests_istio 48f37c7 link /test integ-helm-tests_istio
integ-pilot-multicluster-tests_istio 48f37c7 link /test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Nov 22, 2020
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2020-10-22. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn left review comments

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while needs-rebase Indicates a PR needs to be rebased before being merged size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ostromart @istio-testing @istio-policy-bot @howardjohn