Implement a secured debug interface for istio #31338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/XL
irisdingbj
changed the title
istio-testing
added
the
do-not-merge/work-in-progress
shamsher31
reviewed
Mar 9, 2021
shamsher31
reviewed
Mar 9, 2021
shamsher31
reviewed
Mar 9, 2021
howardjohn
reviewed
Mar 9, 2021
irisdingbj
force-pushed
the
secureddebug
branch
from
c1f319f
to
0fc66ed
Compare
istio-testing
added
size/L
irisdingbj
changed the title
istio-testing
removed
the
do-not-merge/work-in-progress
howardjohn
reviewed
Mar 11, 2021
|
Looks great overall! |
|
/test unit-tests_istio |
irisdingbj
force-pushed
the
secureddebug
branch
from
5ae7089
to
841bcc1
Compare
irisdingbj
added
the
release-notes-none
|
/retest |
|
@howardjohn PTAL, Thanks! |
howardjohn
reviewed
Mar 17, 2021
| By default it will use the default serviceAccount from (istio-system) namespace if the pod is not specified. | ||
| `, | ||
| Example: ` # Retrieve sync status for all Envoys in a mesh | ||
| istioctl x debug syncz |
There was a problem hiding this comment.
I am getting
$ istioctl x debug syncz
Error: resource name may not be empty
There was a problem hiding this comment.
you need specify --xds-address xxxx:15012
There was a problem hiding this comment.
can we improve the error message somehow? Also I am not sure why I need to specify that, given the example doesn't. I want to access incluster istiod
There was a problem hiding this comment.
sure, will address this in the following up PR
howardjohn
reviewed
Mar 17, 2021
howardjohn
approved these changes
Mar 18, 2021
| By default it will use the default serviceAccount from (istio-system) namespace if the pod is not specified. | ||
| `, | ||
| Example: ` # Retrieve sync status for all Envoys in a mesh | ||
| istioctl x debug syncz |
There was a problem hiding this comment.
can we improve the error message somehow? Also I am not sure why I need to specify that, given the example doesn't. I want to access incluster istiod
shamsher31
reviewed
Mar 19, 2021
| } | ||
| if len(args) == 0 { | ||
| return CommandParseError{ | ||
| e: fmt.Errorf("debug type is required"), |
There was a problem hiding this comment.
nit: there is no format specifier here.
This was referenced Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the debug interface secured via xds.
@howardjohn @esnible I put an initial version here to get early feedbacks. Thanks!