Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fully random ports for Envoy #32184

Closed
codefromthecrypt opened this issue Apr 15, 2021 · 1 comment
Closed

Allow fully random ports for Envoy #32184

codefromthecrypt opened this issue Apr 15, 2021 · 1 comment

Comments

@codefromthecrypt
Copy link

codefromthecrypt commented Apr 15, 2021

Describe the feature request
In getenvoy, we have unit and end-to-end tests that would ideally run in parallel. One test is envoy bootstrap, and I noticed that while the envoy admin port can be specified, and pilot's addresses can be set to "127.0.0.1:0" others in the envoy template are hard-coded, notably ports 15020 15021 and 15090. While this isn't a production issue, this also limits the amount of testing that someone can do to serial or indirect ports via running inside docker.

I'd love to see the following changes to tools/packaging/common/envoy_bootstrap.json in descending priority:

  • all ports that refer to core services templatable
  • some solution that allows port 0 at least for the envoy admin port (possibly reading back with --admin-address-path when on the same host eg mock mode)

Describe alternatives you've considered
running serially, running tests, mapping pilot and envoy ports with a docker container driver. These are slow and can lead to flakes especially the former can be flakey as users have to stop all related services on their hosts to avoid effecting behavior.

[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
[x] Developer Infrastructure

Additional context

@howardjohn
Copy link
Member

This is a reasonable request but its a duplicate of #31138 so lets track there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants