Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startTLS support in service entry #33345

Closed
ceastman-ibm opened this issue Jun 9, 2021 · 9 comments
Closed

startTLS support in service entry #33345

ceastman-ibm opened this issue Jun 9, 2021 · 9 comments
Labels
area/networking kind/enhancement lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while

Comments

@ceastman-ibm
Copy link

ceastman-ibm commented Jun 9, 2021

Describe the feature request
Since startTLS support has been added to envoy: envoyproxy/envoy#13112

Can it be used in the protocol section of service entries? something like:

apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
name: postgresql-service-entry
spec:
hosts:

  • postgresql.server.com
    location: MESH_EXTERNAL
    ports:
  • name: tls
    number: 30101
    protocol: STARTTLS
    resolution: DNS

Describe alternatives you've considered

[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Additional context

@adityaanand11
Copy link

#3588

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Dec 7, 2021
@ceastman-ibm
Copy link
Author

@howardjohn how do we keep this issue from getting closed due to staleness?

@GregHanson
Copy link
Member

not stale - I am looking into the implementation

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Dec 8, 2021
@howardjohn
Copy link
Member

Not sure this makes sense. STARTTLS means that the client starts with raw TCP and then 'upgrades' to TLS. protocol: TLS in Istio means we route based on an SNI. The initial connection with STARTTLS does not have SNI, so there is nothing to route beyond protocol: TCP.

Add STARTTLS origination could make sense though.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Jun 7, 2022
@iprasla
Copy link

iprasla commented Jun 9, 2022

This is not a stale issue - this still needs to be addressed.

@remansour
Copy link

Can we get an update or ETA on when this will be addressed?

@GregHanson
Copy link
Member

@remansour there was a PR started here but was eventually abandoned as consensus could not be reached

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Jun 21, 2022
@iprasla
Copy link

iprasla commented Nov 4, 2022

Is there an update on this? It seems like there was discussion and it was suggested that there will be a solution to that. Can it be re-open or be addressed?

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Dec 19, 2022
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-06-21. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking kind/enhancement lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while
Projects
None yet
Development

No branches or pull requests

7 participants