Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The destinationRule wants to support the same functionality as the NGINX error_page #33607

Closed
ada012 opened this issue Jun 24, 2021 · 2 comments

Comments

@ada012
Copy link

ada012 commented Jun 24, 2021

Describe the feature request
The destinationRule wants to support the same functionality as the NGINX error_page
Describe alternatives you've considered

subsets:
  - name: testversion
    labels:
      version: v3
    errorPage:
        code:
            - 503
            - 404
        route:
           # cluster external
            - disable: false
               type: redirect
               url: http://xxx.com
          # cluster internal
           - disable: true
              type: host
              host: ratings.prod.svc.cluster.local
              labels:
                   version: v3

[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[x] Developer Infrastructure

Additional context

Envoy endorses a similar ability
https://github.com/envoyproxy/envoy/blob/main/docs/root/configuration/http/http_conn_man/local_reply.rst

@esnible
Copy link
Contributor

esnible commented Jun 24, 2021

I had the same use case. My solution was custom WebAssembly code, deployed to Envoy using an Istio EnvoyFilter. The code handled HttpCall::onResponseHeaders() and if it saw a 40x/50x it took over, changing body and headers. It was a lot of work and a declarative way to get the same behavior would be great.

@howardjohn
Copy link
Member

This is a duplicate of #29264, lets track there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants