Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration tests: be more conscious about AutoRegisterVM selection #35861

Open
howardjohn opened this issue Nov 3, 2021 · 0 comments
Open

integration tests: be more conscious about AutoRegisterVM selection #35861

howardjohn opened this issue Nov 3, 2021 · 0 comments
Labels
area/test and release feature/Virtual-machine issues related with VM support help wanted Indicates a PR/Issue that needs community help lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed

Comments

@howardjohn
Copy link
Member

Right now it seems like tests random chose one way or the other. I think it would be preferred to have all tests use it by default, and only have 1 test with it disabled (to make sure we have coverage of that case)
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Feb 1, 2022
@howardjohn howardjohn added the lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed label Feb 1, 2022
@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Feb 1, 2022
@kfaseela kfaseela added help wanted Indicates a PR/Issue that needs community help and removed community/help wanted labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test and release feature/Virtual-machine issues related with VM support help wanted Indicates a PR/Issue that needs community help lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@howardjohn @kfaseela @istio-policy-bot