Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How DestinationRule subsets support set-based label selector #36190

Closed
masquee opened this issue Nov 22, 2021 · 3 comments
Closed

How DestinationRule subsets support set-based label selector #36190

masquee opened this issue Nov 22, 2021 · 3 comments
Labels
area/networking kind/enhancement lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while

Comments

@masquee
Copy link
Contributor

masquee commented Nov 22, 2021

Describe the feature request

I have two group of pods which have groupId label, and I want do locality load balance around them (which means they must in a same subset). But I found that labels of subset cannot do the logic of or.

Kubernetes supports set-based label selector, such as

selector:
  matchExpressions:
    - {key: groupId, operator: In, values: [123, 456]}

Can subset support this? Or any other alternatives?

Describe alternatives you've considered

Affected product area (please put an X in all that apply)

[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

@howardjohn
Copy link
Member

It is not currently supported. You would need to make a common label between all of them and select on that.

@masquee
Copy link
Contributor Author

masquee commented Nov 25, 2021

It is not currently supported. You would need to make a common label between all of them and select on that.

@howardjohn Any plan to support this feature?

Make a common label is work, but pod's label will deep coupling with routing config.

I took a rough look at the source code, and it seems that it is not difficult to support this feature. The parameters received by the underlying implementations are a list of labels.

image

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label May 22, 2022
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-11-22. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking kind/enhancement lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while
Projects
None yet
Development

No branches or pull requests

3 participants