Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform objects in shared informers #37092

Closed
howardjohn opened this issue Feb 1, 2022 · 3 comments
Closed

Transform objects in shared informers #37092

howardjohn opened this issue Feb 1, 2022 · 3 comments

Comments

@howardjohn
Copy link
Member

kubernetes/kubernetes#107507 has possibly huge impacts for us to allow us to transform objects 1x at the lowest level. This can reduce memory usage and redundant conversions

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label May 3, 2022
@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label May 13, 2022
@dddddai
Copy link
Member

dddddai commented May 16, 2022

I think we can work on this now as #38721 is merged, and I took a try, but I found it's a little bit risky because we have to find out all necessary fields where we could possibly miss some of them

@howardjohn Do you think it's fair enough to transform objects like this?

@howardjohn
Copy link
Member Author

Yeah TBH even though this was my idea I am a bit skeptical its worth the cost. Its something to keep in mind, but may be better suited for objects that we only need a tiny subset but are very large. For example, if we just needed the list of versions for CRDs or something (hypothetical - we don't have that use case).

@dddddai
Copy link
Member

dddddai commented Jun 2, 2022

How about stripping unnecessary fields(like metadata.managedFields for all resources, it's large and I don't think we ever use it) rather than retaining necessary ones? I think it's much easier and could save memory with few code changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants