Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional containers in gateway Helm chart #38912

Closed
gjacquet opened this issue May 13, 2022 · 1 comment
Closed

Support additional containers in gateway Helm chart #38912

gjacquet opened this issue May 13, 2022 · 1 comment

Comments

@gjacquet
Copy link

Describe the feature request

There are some use cases where it would be useful to run a sidecar container along with the gateway main container.

Gateways chart supports it (https://github.com/istio/istio/blob/master/manifests/charts/gateways/istio-ingress/values.yaml#L72) however the gateway chart to deploy a single gateway does not allow defining any additional containers.

Describe alternatives you've considered

While there are plenty of other way to get this done (forking the chart, using an admission controller etc), adding the option in this chart would be the most convenient.

Affected product area (please put an X in all that apply)

[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

@howardjohn
Copy link
Member

See https://docs.solo.io/gloo-edge/latest/installation/gateway/kubernetes/helm_advanced/; I don't think we can reasonable expose every single possible API field in the gateway.

@zirain zirain closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants