Add podLabels to Gateway Helm Chart

[blhagadorn]

Describe the feature request

Add podLabels to Gateway Helm chart, for just adding labels to the pods (not the Deployment)

Describe alternatives you've considered

Kustomize, forking the chart

Affected product area (please put an X in all that apply)

[ ] Ambient
[ ] Docs
[ X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ X] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

The gateway helm chart doesn't expose podLabels like istiod does:

Gateway:
https://github.com/istio/istio/blob/master/manifests/charts/gateway/values.yaml

IstioD:

istio/manifests/charts/istio-control/istio-discovery/values.yaml

Line 71 in 9ff1e2a

podLabels: {}

istio/manifests/charts/istio-control/istio-discovery/templates/deployment.yaml

Lines 47 to 49 in 9ff1e2a

	{{- range $key, $val := .Values.pilot.podLabels }}
	{{ $key }}: "{{ $val }}"
	{{- end }}

[zirain]

FYI https://istio.io/latest/docs/setup/additional-setup/customize-installation-helm/

[blhagadorn]

That's definitely one way to do it, would it be okay to add to the helm chart as well?

[blhagadorn]

Since it's already in the other helm chart, I think it would bring parity by adding it to the helm chart. What do you think?

[afk42]

Hi @blhagadorn ,
May I ask why this wasn't accepted and merged into the project?
This is some feature that I could really use since I need to add these podLabels due to some internal implementations which I have no control over and we are not currently using Kustomize.
As refereed, this type of configuration is already possible on istio-discovery, so is it also possible to have the same here?

Thanks.

[magdalenakuhn]

Hi @blhagadorn , May I ask why this wasn't accepted and merged into the project? This is some feature that I could really use since I need to add these podLabels due to some internal implementations which I have no control over and we are not currently using Kustomize. As refereed, this type of configuration is already possible on istio-discovery, so is it also possible to have the same here?

Thanks.

Having the same issue! Is there any chance we can expose podLabels as value?