Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway-api: initial implementation of gRPC route #41839

Closed
wants to merge 1 commit into from
Closed

gateway-api: initial implementation of gRPC route #41839

wants to merge 1 commit into from

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented Nov 7, 2022 •
edited by istio-policy-bot

Please provide a description of this PR:

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Nov 7, 2022
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Nov 7, 2022
@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR needs to be rebased before being merged labels Nov 7, 2022
@howardjohn howardjohn marked this pull request as ready for review November 14, 2022 20:41
@istio-testing istio-testing removed do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. needs-rebase Indicates a PR needs to be rebased before being merged labels Nov 14, 2022
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 2, 2022
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Dec 8, 2022
@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Dec 23, 2022
@howardjohn
Copy link
Member Author

still working

@howardjohn howardjohn reopened this Dec 29, 2022
@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Dec 29, 2022
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Jan 29, 2023
@howardjohn
Copy link
Member Author

this is stale but keep open to remind me to finish it

@howardjohn howardjohn reopened this Feb 13, 2023
@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Feb 13, 2023
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Mar 16, 2023
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 16, 2023
@istio-testing
Copy link
Collaborator

istio-testing commented Mar 16, 2023 •
edited

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integ-cni_istio 38c6c57 link true /test integ-cni
integ-pilot-istiodremote_istio 38c6c57 link true /test integ-pilot-istiodremote
integ-pilot_istio 38c6c57 link true /test integ-pilot
integ-pilot-istiodremote-mc_istio 38c6c57 link true /test integ-pilot-istiodremote-mc
integ-pilot-multicluster_istio 38c6c57 link true /test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 22, 2023
@istio-testing
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2023-02-13. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@PeterPanHaiHai
Copy link

reopen @howardjohn @hzxuzhonghu

@howardjohn
Copy link
Member Author

Github won't let me re-open, making a new pr #46336

@howardjohn howardjohn mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costinm costinm Awaiting requested review from costinm

@linsun linsun Awaiting requested review from linsun

@stevenctl stevenctl Awaiting requested review from stevenctl

@ericvn ericvn Awaiting requested review from ericvn

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

Assignees

@ruigulala ruigulala

Labels
lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while needs-rebase Indicates a PR needs to be rebased before being merged release-notes-none Indicates a PR that does not require release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@howardjohn @istio-testing @istio-policy-bot @PeterPanHaiHai @ruigulala