Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit streams per tunnel connection #43443

Open
kyessenov opened this issue Feb 17, 2023 · 5 comments
Open

limit streams per tunnel connection #43443

kyessenov opened this issue Feb 17, 2023 · 5 comments
Labels
area/ambient Issues related to ambient mesh area/networking area/perf and scalability help wanted Indicates a PR/Issue that needs community help

Comments

@kyessenov
Copy link
Contributor

Envoy implementation is limited by the fact that internal listeners handle streams on the same worker as the tunnel listener. Therefore, we cannot handle a very large number of streams on a single tunnel.

We should ensure that we set a low max number of streams (~100 as a first estimate).

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label May 19, 2023
@hzxuzhonghu
Copy link
Member

/not stale

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label May 19, 2023
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Aug 17, 2023
@keithmattix
Copy link
Contributor

Not stale

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Aug 17, 2023
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Nov 16, 2023
@GregHanson
Copy link
Member

not stale

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Nov 29, 2023
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Feb 28, 2024
@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Mar 14, 2024
@hzxuzhonghu hzxuzhonghu reopened this Mar 14, 2024
@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Mar 14, 2024
@hzxuzhonghu hzxuzhonghu removed the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Mar 14, 2024
@howardjohn howardjohn added help wanted Indicates a PR/Issue that needs community help and removed community/help wanted labels Apr 4, 2024
@kevinmingtarja
Copy link

Hi, I'm interested in picking this up if no one's working on it!

@bleggett
Copy link
Contributor

So in istio/ztunnel#931

we added a pooling impl that considers streamcount-per-conn as criteria for starting a new connection, and exposes a ztunnel env var POOL_MAX_STREAMS_PER_CONNECTION to control that (which currently defaults to 100).

Our waypoint config is still hardcoded at 100 streams-per-conn though, which makes customizing POOL_MAX_STREAMS_PER_CONNECTION on the ztunnel side to a number higher than 100 a bad idea if you are using waypoints: https://github.com/istio/istio/blob/master/pilot/pkg/networking/core/listener_waypoint.go#L112

I think this will be mooted by sandwiching, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ambient Issues related to ambient mesh area/networking area/perf and scalability help wanted Indicates a PR/Issue that needs community help
Projects
None yet
Development

No branches or pull requests

8 participants