-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Istio_v0.7.1 chart can't pull image from default image repository defined in value.yaml #4701
Comments
Not clear to me what should be done to correct this in the future other than modify the values.yaml during the branching & tagging process. |
This is bad, we should be using the docker.io/istio repo, not the nightly. looks like this is only an issue with helm, not with the istio.yaml files. |
@hklai @rkpagadala @sebastienvas looks like one more image needs to be substituted when making the official release? |
instead of substituting image, it looks like the hub value in https://github.com/istio/istio/blob/master/install/kubernetes/helm/istio/values.yaml needs to be updated? I am not very familiar with helm, so please bear with me. |
it never worked in previous releases, only in master... hub value in values.yaml is for people to specify their own hubs.... the default one in official release should be docker.io/istio... we should replace it to use that when we generate the official release. |
or shouldn't it be the other way around? The default should be docker.io/istio, if override that to nightly only when someone wants to pick up bleeding edge? |
sure for hub but what about the tag ? |
I think the default was docker.io/istio before, but changed to nightly. @costinm do you know why? tag is similar, you could customize it too based on a local build tag. |
for dev mode/build from source, the makefile should change the hub/tag to HUB and TAG but I'm still curious how the right tag would get in there for the release tar ball ? |
@hklai i downloaded the 0.8 pre build istio-0.8.0-pre20180414-09-15 and it looks okay for pre-release:
Does anyone know where is this configured for the official release? I 'd like to get this fixed in 0.8 as many people has reported helm install not working in the past few releases. |
Both the hub and tag are "injected" by the release pipeline. For the official 0.8.0 build (which will be rebuilt from the release branch), the hub will be docker.io and the tag will be 0.8.0. |
@linsun is there any remaining work that needs to be done here? |
this has worked for me:
We should move to this on master no ? |
env:
install command:
Before install, we need to add templates
_helpers.tpl
to workaround issue: #3895And then:
problem:
We can see the problem from pod creating events:
Analysis:
Try to pull image directly by:
The reason is that default image repository defined in
value.yaml
isn't updated.Confirm it by running:
Workaround:
/cc @gyliu513
The text was updated successfully, but these errors were encountered: