helm: Add default divisor for GOMEMLIMIT and GOMAXPROCS

[Kellen275]

Please provide a description of this PR:
When deploying istio via ArgoCD with auto-sync, this field is flagged as being removed since Kubernetes appears to add the default after-the-fact.

[linux-foundation-easycla]

• ✅login: Kellen275 / (d6d783c)

The committers listed above are authorized under a signed CLA.

[istio-policy-bot]

😊 Welcome @Kellen275! This is either your first contribution to the Istio istio repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

[istio-testing]

Hi @Kellen275. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[howardjohn]

Is this really the only field that we don't have a default explicitly set?

FWIW I think this is solveable already in argo. Not an expert but I think argoproj/argo-cd#11574 is the relevant link. Basically Argo is not aware of defaults by default.

I think its a bit silly to expect every helm chart to explicitly specify every default value, and Argo pushes this problem to all charts in the world. But it is also cheap to fix so probably worth while.

[howardjohn]

we have this in many places, is there a reason only the cni chart was changed?

[howardjohn]

argoproj/argo-cd#11139

[Kellen275]

In my particular case, I'm attempting to sync the following istio charts: base, istiod, cni, and gateway.

This CNI chart is the only one Argo is reporting a diff on. Admittedly I haven't explored the other istio charts or different configurations of the same charts.

[istio-policy-bot]

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2024-03-14. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.