Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.21] pilot: fix bug in endpoint updates #51026

Closed
istio-testing opened this issue May 14, 2024 · 1 comment
Closed

[release-1.21] pilot: fix bug in endpoint updates #51026

istio-testing opened this issue May 14, 2024 · 1 comment
Assignees

Comments

@istio-testing
Copy link
Collaborator

Manual cherrypick required.

#50746 failed to apply on top of branch "release-1.21":

Applying: pilot: fix bug in endpoint updates
Using index info to reconstruct a base tree...
M	pilot/pkg/model/endpointshards.go
M	pilot/pkg/serviceregistry/serviceregistry_test.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/serviceregistry/serviceregistry_test.go
Auto-merging pilot/pkg/model/endpointshards.go
Applying: Prod impl
Using index info to reconstruct a base tree...
M	pilot/pkg/model/endpointshards.go
M	pilot/pkg/model/service.go
M	pilot/pkg/serviceregistry/serviceregistry_test.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/serviceregistry/serviceregistry_test.go
Auto-merging pilot/pkg/model/service.go
Auto-merging pilot/pkg/model/endpointshards.go
CONFLICT (content): Merge conflict in pilot/pkg/model/endpointshards.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Prod impl
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@tanujd11
Copy link
Member

Closing the issue as the 1.21 cherry-pick was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants