Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difference between ci clusters and person cluster #655

Closed
yutongz opened this issue Sep 3, 2017 · 2 comments
Closed

Difference between ci clusters and person cluster #655

yutongz opened this issue Sep 3, 2017 · 2 comments

Comments

@yutongz
Copy link
Contributor

yutongz commented Sep 3, 2017

@kyessenov and @douglas-reid reported in #647 and heard people complained this before. It seems testing clusters bring in more flakiness, we need to figure out what's the difference before everyone gives up CI tests.

Possible reasons:

  1. Tests don't cleanup properly and pollute the environment
  2. Multiple tests effect each other
  3. Resource limits (which I don't think so)
  4. Different setting of clusters

Testing clusters are in 1.7.2 which is extinct (either in console or through api). It's hard for developers and customers to reproduce either successful or failed cases.
@douglas-reid
Copy link
Contributor

fwiw, i think this was an extra special set of things needing isolation, as CRD definitions from different PRs (from different repos) were causing cluster-wide issues when committed. So, there was at least some of (2) at play. It also seems like there is something related to istio ingress that is triggered in "noisy" environments. Private clusters seem to avoid whatever that issue is, but no one has root-caused it.

@yutongz
Copy link
Contributor Author

yutongz commented Sep 28, 2017

fixed

@yutongz yutongz closed this as completed Sep 28, 2017
mandarjog pushed a commit that referenced this issue Oct 31, 2017
@linsun @istio-merge-robot
fix for istio-initializer needs to ignore hostNetwork pod specs (#1440)
1ddd19b 
Automatic merge from submit-queue

fix for istio-initializer needs to ignore hostNetwork pod specs

**What this PR does / why we need it**:

PR for istio/istio.io#655, see #655 for details

**Release note**:

```release-note
When a pod uses hostNetwork: true, the pod will be disabled from side car injection on purpose because we don't want the envoy side car to change the network configuration at the host level.
```
0x01001011 pushed a commit to thedemodrive/istio that referenced this issue Jul 16, 2020
@kyessenov @istio-testing
policy: add missing APA attribute bindings (istio#655)
890f95f 
* add missing APA attribute bindings

Signed-off-by: Kuat Yessenov <kuat@google.com>

* review

Signed-off-by: Kuat Yessenov <kuat@google.com>

* rename to output

Signed-off-by: Kuat Yessenov <kuat@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@douglas-reid @yutongz