Support define configscope for k8s service #10598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxuzhonghu
requested review from
costinm and
rshriram
and removed request for
vadimeisenbergibm,
geeknoid and
costinm
hzxuzhonghu
commented
Dec 24, 2018
pkg/features/pilot/pilot.go
Outdated
| // ServiceScopeLabel configs the scope the service visible to. | ||
| // "PUBLIC" which is the default, indicates it is reachable within the mesh | ||
| // "PRIVATE" indicates it is reachable within its namespace | ||
| ServiceScopeLabel = "istio-config-scope" |
There was a problem hiding this comment.
An alternate choice is to set this in annotation, any suggestion?
There was a problem hiding this comment.
I prefer annotations. Other parts of istio use annotations. The availability zone thing should also be using annotations (not to mention its incorrect after your recent work on using regions, zones, etc..).
rshriram
reviewed
Dec 29, 2018
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, rshriram The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support define Service configScope by annotation
"networking.istio.io/configScope"