-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A couple cherry-picks from master #11238
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
/test e2e-simpleTests |
/test e2e-simpleTests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglas-reid, hklai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-simpleTests |
@douglas-reid simpleTest failed consistently few times in a row (not the same reasons however). Do you see how this PR might have broken it? |
/test e2e-simpleTests |
@hklai i'll take a look now. |
@hklai I don't believe that this PR could be the cause of those failures. They (mostly) are init errors (with one prometheus test error -- which I think someone sent a PR to fix last week). Is it possible that something on Prow has changed ? |
@douglas-reid i think i found the culprit and reverted it. #11331 (comment) Rerunning the test now. |
@hklai: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
All required tests have passed. Merging. |
No description provided.