Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple cherry-picks from master #11238

Merged
merged 2 commits into from Jan 28, 2019
Merged

A couple cherry-picks from master #11238

merged 2 commits into from Jan 28, 2019

Conversation

hklai
Copy link
Contributor

@hklai hklai commented Jan 24, 2019

No description provided.

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Jan 24, 2019
@hklai
Copy link
Contributor Author

hklai commented Jan 28, 2019

/test e2e-simpleTests
/test istio-unit-tests

@hklai
Copy link
Contributor Author

hklai commented Jan 28, 2019

/test e2e-simpleTests

Copy link
Contributor

@douglas-reid douglas-reid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglas-reid, hklai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai
Copy link
Contributor Author

hklai commented Jan 28, 2019

/test e2e-simpleTests

@hklai
Copy link
Contributor Author

hklai commented Jan 28, 2019

@douglas-reid simpleTest failed consistently few times in a row (not the same reasons however). Do you see how this PR might have broken it?

@hklai
Copy link
Contributor Author

hklai commented Jan 28, 2019

/test e2e-simpleTests

@douglas-reid
Copy link
Contributor

@hklai i'll take a look now.

@douglas-reid
Copy link
Contributor

@hklai I don't believe that this PR could be the cause of those failures. They (mostly) are init errors (with one prometheus test error -- which I think someone sent a PR to fix last week). Is it possible that something on Prow has changed ?

@hklai
Copy link
Contributor Author

hklai commented Jan 28, 2019

@douglas-reid i think i found the culprit and reverted it. #11331 (comment)

Rerunning the test now.

@istio-testing
Copy link
Collaborator

@hklai: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-multicluster-e2e.sh b044314 link /test istio-pilot-multicluster-e2e
prow/istio-integ-k8s-tests.sh b044314 link /test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai hklai added cla: yes and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Jan 28, 2019
@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@hklai
Copy link
Contributor Author

hklai commented Jan 28, 2019

All required tests have passed. Merging.

@hklai hklai merged commit 010d5c2 into istio:release-1.1 Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants