Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VirtualService examples that no longer have an effect #11892

Merged
merged 4 commits into from Feb 28, 2019
Merged

Remove VirtualService examples that no longer have an effect #11892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8886565
Remove no-longer-needed VirtualServices
esnible Feb 20, 2019
830e0f4
Modifications after testing using release-1.1-20190214-09-16
esnible Feb 20, 2019
df1f6b5
Correct comment explanation
esnible Feb 20, 2019
7e2c268
Include pythonhosted.org for 'pypi' and sort/format/dedup the github …
esnible Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 9 additions & 30 deletions samples/external/github.yaml
View file
Open in desktop
Expand Up @@ -17,24 +17,6 @@ spec:
name: https
protocol: HTTPS
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing with release-1.1-20190214-09-16 showed this was needed.

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
name: github-https
spec:
hosts:
- github.com
tls:
- match:
- port: 443
sniHosts:
- github.com
route:
- destination:
host: github.com
port:
number: 443
---
# For TCP services the IP ranges SHOULD be specified to avoid problems
# if multiple SEs use the same port number.
# See https://istio.io/blog/2018/egress-tcp/#mesh-external-service-entry-for-an-external-mysql-instance
Expand All @@ -46,27 +28,24 @@ spec:
hosts:
- dummy.github.com # not used
addresses: # from https://help.github.com/articles/about-github-s-ip-addresses/
- "192.30.252.0/22"
- "185.199.108.0/22"
- "140.82.112.0/20"
- "192.30.252.0/22"
- "185.199.108.0/22"
- "140.82.112.0/20"
- "13.229.188.59/32"
- "13.250.177.223/32"
- "140.82.112.0/20"
- "18.194.104.89/32"
- "18.195.85.27/32"
- "35.159.8.160/32"
- "52.74.223.119/32"
- "192.30.252.153/32"
- "192.30.252.154/32"
- "185.199.108.0/22"
- "185.199.108.153/32"
- "185.199.109.153/32"
- "185.199.110.153/32"
- "185.199.111.153/32"
- "54.87.5.173/32"
- "54.166.52.62/32"
- "192.30.252.0/22"
- "192.30.252.153/32"
- "192.30.252.154/32"
- "23.20.92.3/32"
- "35.159.8.160/32"
- "52.74.223.119/32"
- "54.166.52.62/32"
- "54.87.5.173/32"
ports:
- name: tcp
number: 22
Expand Down
40 changes: 8 additions & 32 deletions samples/external/pypi.yaml
View file
Open in desktop
Expand Up @@ -17,26 +17,7 @@ spec:
name: https
protocol: HTTPS
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this extra line?

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
name: python-https
spec:
hosts:
- pypi.python.org
tls:
- match:
- port: 443
sniHosts:
- pypi.python.org
route:
- destination:
host: pypi.python.org
port:
number: 443
---
# pypi.python.org may 301 redirect to pypi.org, so we need this too.

apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
Expand All @@ -49,20 +30,15 @@ spec:
name: https
protocol: HTTPS
---
# pip install may fetch files from files.pythonhosted.org
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
kind: ServiceEntry
metadata:
name: pypi-https
name: pythonhosted-https
spec:
hosts:
- pypi.org
tls:
- match:
- port: 443
sniHosts:
- pypi.org
route:
- destination:
host: pypi.org
port:
number: 443
- files.pythonhosted.org
ports:
- number: 443
name: https
protocol: HTTPS