feat(mixer plugin): add ignore_forwarded_attributes for gateways #17692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateways Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
|
@rshriram I know that you have use cases around using the forwarded headers. Perhaps we can discuss here. I'd like to understand how your needs balance with the two open issues, etc. |
|
/test integ-mixer-k8s-tests_istio |
rshriram
reviewed
Oct 10, 2019
|
ping @mandarjog @kyessenov. i'll be OOO for a few days. if this needs adjustment, hopefully someone else can take over. |
kyessenov
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another in the series of PRs meant to address observed issues with telemetry at gateways. It follows on istio/api#1085 to set the newly introduced field in the (http) mixer client config when dealing with gateways. Two more PRs will be needed to address (1) proxy functionality in the presence of the new field and (2) update the version of the proxy in istio/istio.
See: #15188, #12063
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ X ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure