Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.9] Fixes #30868. Added the missing IPv6 rule. #33439

Merged
merged 4 commits into from Jun 15, 2021
Merged

[release-1.9] Fixes #30868. Added the missing IPv6 rule. #33439

merged 4 commits into from Jun 15, 2021

Conversation

istio-testing
Copy link
Collaborator

This is an automated cherry-pick of #33221

@sha-rath @istio-testing
Fixes istio#30868. Added the missing ip6tables rule.
bd18915 
ip6tables now includes the rule to redirect traffic to Envoy
for the outbound ports listed using the annotation
traffic.sidecar.istio.io/includeOutboundPorts
@sha-rath @istio-testing
Added test case to check ipv6 rules when outbound ports are included
2f74a8c
@sha-rath @istio-testing
Added release notes
b8d60a0
@sha-rath @istio-testing
Updated releasenotes/notes/30868.yaml
49e0393
@istio-testing istio-testing requested a review from a team June 15, 2021 16:04
@istio-testing istio-testing mentioned this pull request Jun 15, 2021
Merged
@istio-testing istio-testing added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. labels Jun 15, 2021
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 15, 2021
@google-cla
Copy link

google-cla bot commented Jun 15, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Jun 15, 2021
@jacob-delgado
Copy link
Contributor

cc @sha-rath We need your consent to get this backported.

@sha-rath
Copy link
Contributor

@jacob-delgado I'm okay with cherry-picking this one. Do I need to trigger something for cla again?

@jacob-delgado
Copy link
Contributor

@jacob-delgado I'm okay with cherry-picking this one. Do I need to trigger something for cla again?

You need to say @googlebot I consent. on both PRs. Thanks!

@google-cla
Copy link

google-cla bot commented Jun 15, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@sha-rath
Copy link
Contributor

Ok, thank you! I just got that email.

@sha-rath
Copy link
Contributor

@googlebot I consent

@google-cla google-cla bot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Jun 15, 2021
@istio-testing istio-testing merged commit 1ffa854 into istio:release-1.9 Jun 15, 2021
libesz pushed a commit to libesz/istio that referenced this pull request Nov 11, 2021
@istio-testing @sha-rath
[release-1.9] Fixes istio#30868. Added the missing IPv6 rule. (istio#…
887e497 
…33439)

* Fixes istio#30868. Added the missing ip6tables rule.

ip6tables now includes the rule to redirect traffic to Envoy
for the outbound ports listed using the annotation
traffic.sidecar.istio.io/includeOutboundPorts

* Added test case to check ipv6 rules when outbound ports are included

* Added release notes

* Updated releasenotes/notes/30868.yaml

Co-authored-by: sharathchandra <sharath.chandra.balachandra@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-delgado jacob-delgado jacob-delgado approved these changes

Assignees

@jacob-delgado jacob-delgado

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@istio-testing @jacob-delgado @sha-rath