-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix(accesslog): allow different provider between modes #39696
bugfix(accesslog): allow different provider between modes #39696
Conversation
Hi @j2gg0s. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this seems related to #39521 |
Yes, it is related but not same. This PR don't change current logic and just fix obvious unexpected behavior. |
I think the root case is |
Yes, two PR is conflict But if we want to change Telemetry's AccessLogging behavior, Maybe it's better to define what we expected before coding. one Telemetry has many AccessLoging,one HCM also has many access_log. |
@j2gg0s: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-06-30. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions. Created by the issue and PR lifecycle manager. |
Please provide a description of this PR:
Take workload's mode into consideration, when compute inScopeProviders.
So, we can allow user config different access log providers for different mode.
This maybe what we expected.
Please check any characteristics that apply to this pull request.