Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix x wait when PILOT_ENABLE_CONFIG_DISTRIBUTION_TRACKING is not true #43023

Merged
merged 5 commits into from Mar 17, 2023
Merged

Fix x wait when PILOT_ENABLE_CONFIG_DISTRIBUTION_TRACKING is not true #43023

merged 5 commits into from Mar 17, 2023

Conversation

hanxiaop
Copy link
Member

@hanxiaop hanxiaop commented Jan 27, 2023 •
edited by istio-policy-bot

Please provide a description of this PR:
Fix #42967

@hanxiaop hanxiaop requested review from a team as code owners January 27, 2023 14:46
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2023
@ericvn
Copy link
Contributor

ericvn commented Jan 27, 2023 •
edited

release notes error:

Executing ../tools/cmd/schema-validator/schema-validator  --schemaPath ../tools/cmd/gen-release-notes/release_notes_schema.json --documentPath ./releasenotes/notes/wait-when-distribution-tracing-disabled.yaml
Validating ./releasenotes/notes/wait-when-distribution-tracing-disabled.yaml against ../tools/cmd/gen-release-notes/release_notes_schema.json
The document is not valid. See errors :
- issue: Invalid type. Expected: array, given: null
~/prow/go/src/istio.io/istio

Failed to validate release notes. Exiting

@hanxiaop @ericvn
Update releasenotes/notes/wait-when-distribution-tracing-disabled.yaml
5fbe9eb 
Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
@hanxiaop hanxiaop requested a review from ericvn February 7, 2023 04:59
@therealmitchconnors
Copy link
Contributor

Because this is fixing a bug, we will need a test case. Other than that LGTM.

@hanxiaop
apply comments and add test
7ae3a53
@hanxiaop
Merge branch 'fix-x-wait-when-distribution-tracing-disabled' of githu…
496c1f5 
…b.com:hanxiaop/istio into fix-x-wait-when-distribution-tracing-disabled
ericvn
ericvn approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes look good. Thanks.

@hanxiaop hanxiaop added cherrypick/release-1.17 Set this label on a PR to auto-merge it to the release-1.17 branch cherrypick/release-1.16 Set this label on a PR to auto-merge it to the release-1.16 branch labels Mar 10, 2023
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Mar 11, 2023
@hanxiaop
Copy link
Member Author

not stale

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Mar 11, 2023
@istio-testing istio-testing merged commit c62171f into istio:master Mar 17, 2023
@istio-testing istio-testing mentioned this pull request Mar 17, 2023
Merged
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #43979

@istio-testing istio-testing mentioned this pull request Mar 17, 2023
Merged
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #43980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhlsunshine zhlsunshine zhlsunshine approved these changes

@ericvn ericvn ericvn approved these changes

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@GregHanson GregHanson GregHanson approved these changes

@therealmitchconnors therealmitchconnors Awaiting requested review from therealmitchconnors

Assignees

@zhlsunshine zhlsunshine

Labels
area/user experience cherrypick/release-1.16 Set this label on a PR to auto-merge it to the release-1.16 branch cherrypick/release-1.17 Set this label on a PR to auto-merge it to the release-1.17 branch size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

istioctl experimental wait has undecipherable message if value isn't set
8 participants
@hanxiaop @istio-policy-bot @ericvn @therealmitchconnors @istio-testing @zhlsunshine @hzxuzhonghu @GregHanson