Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Kiali addon to v1.63.1 #43052

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Upgrade Kiali addon to v1.63.1 #43052

merged 1 commit into from
Feb 1, 2023

Conversation

jmazzitelli
Copy link
Member

@jmazzitelli jmazzitelli commented Jan 30, 2023 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

Upgrades the kiali addon to the latest 1.63.1

Part of kiali/kiali#5773

@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 30, 2023
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 30, 2023
@jmazzitelli jmazzitelli added cherrypick/release-1.17 Set this label on a PR to auto-merge it to the release-1.17 branch and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2023
@jmazzitelli
Copy link
Member Author

added cherry pick 1.17 label since this is for inclusion with 1.17 addons.

@jmazzitelli jmazzitelli mentioned this pull request Jan 30, 2023
Closed
@jmazzitelli
Copy link
Member Author

Kiali 1.63.1 is not yet released, but we want this in istio 1.17 so I'm taking the do-not-merge label off so we can merge this. Kiali 1.63.1 will be released before 1.17... and this PR will work now anyway so it is testable (it will just pull in 1.63.0 image, and the only thing different will be the warning saying "1.63.0 is not compatible with Istio 1.17" - that's what we are adding to 1.63.1 - the compatibility matrix update to show 1.63 is compatible with 1.17.

@jmazzitelli jmazzitelli removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 31, 2023
@jmazzitelli jmazzitelli marked this pull request as ready for review January 31, 2023 13:56
@jmazzitelli jmazzitelli requested review from a team as code owners January 31, 2023 13:56
@jmazzitelli
Copy link
Member Author

Bah! never mind - yeah, the kiali 1.63.1 helm charts aren't published and the CI test tries to get it (I guess it runs gen.sh to test). So we'll have to wait for Kiali 1.63.1 to be released. I'll try to see if that can be done this week.

ericvn
ericvn approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes look good.

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2023
@jmazzitelli
Copy link
Member Author

kiali 1.63.1 released - helm charts now available. re-running CI

@jmazzitelli
Copy link
Member Author

everything is green and ready - this just needs the appropriate approvals to merge.

zirain
zirain approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@istio-testing istio-testing merged commit d22c069 into istio:master Feb 1, 2023
@istio-testing istio-testing mentioned this pull request Feb 1, 2023
Merged
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #43075

@jmazzitelli jmazzitelli deleted the upgrade-kiali branch February 1, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

@ericvn ericvn ericvn approved these changes

@lei-tang lei-tang lei-tang approved these changes

Assignees
No one assigned
Labels
area/environments cherrypick/release-1.17 Set this label on a PR to auto-merge it to the release-1.17 branch size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jmazzitelli @istio-testing @zirain @ericvn @lei-tang @istio-policy-bot