Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cleaning up workloadentry with same ip and network #43951

Merged
merged 2 commits into from Mar 17, 2023
Merged

fix cleaning up workloadentry with same ip and network #43951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d605f4b
fix cleaning up workloadentry with same ip and network
Mar 15, 2023
7946e7d
release note
Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion pilot/pkg/autoregistration/controller.go
View file
Open in desktop
Expand Up @@ -608,5 +608,11 @@ func workloadEntryFromGroup(name string, proxy *model.Proxy, groupCfg *config.Co
}

func makeProxyKey(proxy *model.Proxy) string {
return string(proxy.Metadata.Network) + proxy.IPAddresses[0]
key := strings.Join([]string{
string(proxy.Metadata.Network),
proxy.IPAddresses[0],
proxy.Metadata.AutoRegisterGroup,
proxy.Metadata.Namespace,
}, "~")
return key
}
11 changes: 11 additions & 0 deletions releasenotes/notes/43951.yaml
View file
Open in desktop
@@ -0,0 +1,11 @@
apiVersion: release-notes/v2
kind: bug-fix
area: traffic-management
issue:
- 43950

releaseNotes:
- |
**Fixed** WorkloadEntry resources never being cleaned up if multiple
WorkloadEntries were auto-registered with the same IP and network.