rafctor LookupCluster #44468
rafctor LookupCluster #44468
Conversation
istio-testing
added
the
size/L
| ) | ||
| } | ||
|
|
||
| var providerLookupClusterFailures = monitoring.NewSum( |
There was a problem hiding this comment.
I think Gauge is better, we can record which cluster look up failed rather than always increasing the num
There was a problem hiding this comment.
when to decrease the count?
There was a problem hiding this comment.
Please refer to envoyfilter patching metric, the sum number here is meaningless, it oculd be unlimited big
There was a problem hiding this comment.
For a counter, user should care about rate or increase.
if you are talking about pilot_envoy_filter_status, it's disabled by default.
There was a problem hiding this comment.
cc @ramaraochavali , do you know why it's disabled?
There was a problem hiding this comment.
It is disabled because of possible performance impact. People who want will only enable it in dev envs
There was a problem hiding this comment.
After take a look at istio.io/pkg/monitoring, it's impossible to reset all metrics to 0 when services or telemetries chaged.
cc @hzxuzhonghu
Please provide a description of this PR: