add support for extension with matcher in wasm conversion #45889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-policy-bot
added
the
release-notes-none
istio-testing
added
the
size/M
|
cc: @kyessenov |
11 tasks
|
@istio/wg-policies-and-telemetry-maintainers can you PTAL? |
kyessenov
reviewed
Jul 14, 2023
| @@ -144,6 +145,20 @@ func tryUnmarshal(resource *anypb.Any) (*core.TypedExtensionConfig, *wasm.Wasm, | |||
| wasmLog.Debugf("typed extension config %+v does not contain wasm http filter", typedStruct) | |||
| return nil, nil, nil | |||
| } | |||
| case ec.GetTypedConfig().TypeUrl == xds.ExtensionWithMatcher: | |||
There was a problem hiding this comment.
I'm confused how this works end-to-end? We need to preserve the matcher and rewrite Wasm config, so I expect the matcher to be somehow re-created?
kyessenov
reviewed
Jul 14, 2023
| @@ -418,6 +429,23 @@ var extensionConfigMap = map[string]*core.TypedExtensionConfig{ | |||
| }, | |||
| }, | |||
| }), | |||
| "remote-load-success-extension-matcher": buildAnyExtensionConfig("remote-load-success", &matcher.ExtensionWithMatcher{ | |||
| ExtensionConfig: buildAnyExtensionConfig("remote-load-success", &wasm.Wasm{ | |||
There was a problem hiding this comment.
This is not a realistic config, you need a matcher as well.
|
Closing this as this does not completely solve all use cases. envoyproxy/envoy#28463 should help to build complicated matcher conditions with ECDS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only support WASM directly under extension config. This PR adds support for
ExtensionWithMatcherso that we can use conditional WASM using Envoy filters.