Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update the doc of the --log_rotate_max_age #50662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

doc: update the doc of the --log_rotate_max_age #50662

wants to merge 1 commit into from

Conversation

doujiang24
Copy link
Contributor

@doujiang24 doujiang24 commented Apr 24, 2024 •
edited by istio-policy-bot

No description provided.

@doujiang24
doc: update the doc of the --log_rotate_max_age.
1a33868 
Signed-off-by: doujiang24 <doujiang24@gmail.com>
@doujiang24 doujiang24 requested a review from a team as a code owner April 24, 2024 08:56
@istio-policy-bot
Copy link

😊 Welcome @doujiang24! This is either your first contribution to the Istio istio repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Apr 24, 2024
@istio-testing
Copy link
Collaborator

Hi @doujiang24. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wulianglongrd
wulianglongrd reviewed Apr 24, 2024
View reviewed changes
pkg/log/options.go
// be automatically rotated over time, based on the rotation parameters such
// as RotationMaxSize and RotationMaxAge. The default is to not rotate.
// be automatically rotated over time, based on the rotation parameter:
// RotationMaxSize.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete RotationMaxAge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RotationMaxAge does not affect file rotation, just affect file backups instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wulianglongrd wulianglongrd wulianglongrd left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/docs needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doujiang24 @istio-policy-bot @istio-testing @wulianglongrd