New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change bookinfo gateway Port to 80 from 8080 #50693
base: master
Are you sure you want to change the base?
Conversation
The sample bookinfo example doesn't work with the istio-ingressgateway and bookinfo gateway because of port mismatch. istio-ingressgateway.yaml ``` - name: http2 nodePort: 31156 port: 80 protocol: TCP targetPort: 80 ``` bookinfo.gateway ``` port: name: http number: 8080 protocol: HTTP ``` This will cause error when accessing locally. (mac+minikube) curl http://localhost:80/productpage curl: (56) Recv failure: Connection reset by peer Changing to port 80 works as expected.
😊 Welcome @shweshi! This is either your first contribution to the Istio istio repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
The committers listed above are authorized under a signed CLA. |
Hi @shweshi. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If this PR doens't get merge or meanwhile for people facing this issue:
The changes will be applied, try the curl again and it should work.
|
I recall the targetPort of ingressgateway should be |
@zirain targetPort is
So either we need to make change in bookinfo gateway or in istio ingress gateway to have target port as 8080 to make the bookinfo apps works. |
Changing this would reintroduce #45726 (comment). There is a mismatch in the configuration of the gateway depending on which chart is used (gateway vs gateways): istio/manifests/charts/gateways/istio-ingress/values.yaml Lines 19 to 22 in f25b023
|
Please provide a description of this PR:
The sample bookinfo example doesn't work with the istio-ingressgateway and bookinfo gateway because of port mismatch.
istio-ingressgateway.yaml
bookinfo.gateway
This will cause error when accessing locally. (mac+minikube)
Changing to port 80 works as expected.
bookinfo.gateway
This is causing issues while testing out the sample bookinfo and the documentation doesn't provide anything to fix the issue.