Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualService simple merging of http routes at Gateway #8114

Merged
merged 14 commits into from Aug 23, 2018

Conversation

rshriram
Copy link
Member

Replica of PR from #8113

Signed-off-by: Shriram Rajagopalan shriramr@vmware.com

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
Shriram Rajagopalan added 4 commits August 21, 2018 16:35
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram

If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #8114 into master will increase coverage by 1%.
The diff coverage is 62%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #8114    +/-   ##
=======================================
+ Coverage      71%     71%    +1%     
=======================================
  Files         374     374            
  Lines       32994   33015    +21     
=======================================
+ Hits        23212   23323   +111     
+ Misses       8763    8677    -86     
+ Partials     1019    1015     -4
Impacted Files Coverage Δ
pilot/pkg/networking/util/util.go 26% <ø> (ø) ⬆️
pilot/pkg/networking/core/v1alpha3/httproute.go 25% <0%> (+1%) ⬆️
pilot/pkg/networking/core/v1alpha3/gateway.go 0% <0%> (ø) ⬆️
pilot/pkg/networking/core/v1alpha3/route/route.go 35% <86%> (+6%) ⬆️
mixer/adapter/rbac/util.go 56% <0%> (-13%) ⬇️
mixer/pkg/protobuf/yaml/resolver.go 59% <0%> (-1%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 66% <0%> (ø) ⬇️
mixer/pkg/protobuf/yaml/pool.go 100% <0%> (ø) ⬆️
pilot/pkg/serviceregistry/consul/monitor.go 81% <0%> (ø) ⬆️
mixer/adapter/prometheus/prometheus.go 100% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d24a7ea...a5b8534. Read the comment docs.

Shriram Rajagopalan added 4 commits August 21, 2018 22:36
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
@rshriram rshriram changed the title VirtualService simple merging of http routes VirtualService simple merging of http routes at Gateway Aug 22, 2018
Shriram Rajagopalan added 4 commits August 22, 2018 16:00
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
@rshriram
Copy link
Member Author

/test e2e-mixer-no_auth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants